search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

Acessing `ResolvedLibraryResult` inside `MultiCorrectionProducer` #57092

Closed FMorschel closed 6 days ago

FMorschel commented 1 week ago

For https://dart-review.googlesource.com/c/sdk/+/386020 (https://github.com/dart-lang/sdk/issues/56830), I need access to ResolvedLibraryResult for walking up the part files and getting all ImportDirectives. Similar to what was done for Go to Import at https://dart-review.googlesource.com/c/sdk/+/394200.

I'll open a Cl for adding this to MultiCorrectionProducer and link it here.

dart-github-bot commented 1 week ago

Summary: The user needs access to ResolvedLibraryResult within MultiCorrectionProducer to walk up part files and retrieve all ImportDirectives, similar to the implementation in Go to Import. They will create a CL to add this functionality and link it to the issue.

FMorschel commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/395420

FMorschel commented 1 week ago

I've added you, @bwilkerson, as a reviewer there, can you please review this? There are lots of files on this CL with small changes but this weekend I had to fix merge conflicts twice on the same day already 😅 (because of the big file count). scheglov has already guided me through this change, reviewed everything and approved it. Thanks for your time!