search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

moving `dart-lang/linter` issues into this repo #57109

Closed devoncarew closed 2 days ago

devoncarew commented 6 days ago

Hi, as the tail end of https://github.com/dart-lang/sdk/issues/59165, we'll be moving the issues from dart-lang/linter into this repo.

Note that there are currently ~750 open issues in the linter repo. For people who are currently watching this repository (Watch > All Activity), that will create a lot of notifications. You may want to temporarily switch to the Participating and @mentions level of notifications to reduce the number of emails generated.

We'll likely do the move during the day of Monday, Nov. 18th (this coming Monday), and will close this issue when the move is complete; you could then restore normal notifications then.

devoncarew commented 2 days ago

The issue move is about half way through (we hit some rate limit issues during the move yesterday).

devoncarew commented 2 days ago

This is now complete.

gnprice commented 1 day ago

Here's a somewhat concerning GitHub bug that seems to have been exercised by the moves: it apparently caused an edit to a PR description in an unrelated repo.

I'm not sure there's any particular action to be taken on this. Mentioning it here partly in case anyone sees other examples, so that a pattern emerges. Hopefully the issue is rare and there weren't any other examples.

Specifically, the PR https://github.com/zulip/zulip-flutter/pull/29, in a Zulip repo, had had a reference #28 to PR 28 in that repo. Yesterday it was edited to instead read dart-lang/sdk#57174, pointing to dart-lang/sdk#57174 .

I suspect what happened is that dart-lang/sdk#57174 was formerly issue 28 in dart-lang/linter, and so after the move some job inside GitHub was looking for references to the old dart-lang/linter#28 and updating them to point to dart-lang/sdk#57174. And then, somehow, it picked up our reference to zulip/zulip-flutter#28, in another zulip/zulip-flutter PR, and decided that that was a reference to dart-lang/linter#28 and needed rewriting too.

We noticed the edit because GitHub sent a webhook for it, identifying @devoncarew as the user making the edit, and a bot of ours posted it like normal in our GitHub notification-firehose channel. The edit doesn't show up in the edit history for the PR in the GitHub web UI.

The linked issue dart-lang/sdk#57174 is one that was moved from dart-lang/linter. Oddly, that move happened more than a day before the spurious edit. But given the attribution to @devoncarew (who did the move), I think the edit must still have been triggered by the move. Perhaps the rewrites of old references are done in a queued job that was just slow.

The issue is old, dated from 2015, so it seems plausible that it had been issue 28 in dart-lang/linter. (I don't know an easy way to check that.)