search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

Json codable no type assumption in custom fromJson #59581

Open cedvdb opened 1 day ago

cedvdb commented 1 day ago

This allows an user defined class to have a fromJson method with a parameter that is not a Map. Before this change the @JsonCodable macro would assume the parameter type was a Map. This PR uses the type of the parameter instead.

Note: I have this weird behavior where I can only run the tests with the macros enabled once per branch, so I have to switch branches and run the tests on another.

copybara-service[bot] commented 23 hours ago

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/396629

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 23 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 20 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 20 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 13 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 13 hours ago

https://dart-review.googlesource.com/c/sdk/+/396629 has been updated with the latest commits from this pull request.