dart-lang / setup-dart

A GitHub Action to install and setup a Dart SDK.
BSD 3-Clause "New" or "Revised" License
194 stars 38 forks source link

updates for the latest version of extension types #100

Closed devoncarew closed 1 year ago

devoncarew commented 1 year ago

This addresses a recent analysis issue - lib/node/process.dart:17:21 - Extension types can't declare instance fields. Try replacing the field with a getter. - extension_type_declares_instance_field.


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
srujzs commented 1 year ago

I'm okay with this (especially since we don't use it a setter), but note that this an error in the analyzer that I filed an issue for: https://github.com/dart-lang/sdk/issues/53226.

devoncarew commented 1 year ago

Ah! I would like to land as that'll get the CI green, but it sounds like this is a workaround for an analyzer / extension types issue.