dart-lang / setup-dart

A GitHub Action to install and setup a Dart SDK.
BSD 3-Clause "New" or "Revised" License
194 stars 38 forks source link

debugging issues around specifying the latest patch release #108

Closed devoncarew closed 1 year ago

devoncarew commented 1 year ago

Investigation around https://github.com/dart-lang/setup-dart/issues/107.


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
devoncarew commented 1 year ago

Note that the build failure here is due to the action now requiring 3.3.0-0 to build, but the dev channel is not yet on a 3.3.0 version. This doesn't effect the behavior of the action itself, just our build validation bot.

devoncarew commented 1 year ago

Thanks for the reviews; updated for review feedback and for a fix from https://github.com/dart-lang/setup-dart/issues/107#issuecomment-1753713905.

athomas commented 1 year ago

FYI, build is still failing because of the 3.3.0-0 SDK requirement. It will start working on Thu when the first 3.3 dev release gets published.