dart-lang / site-www

Source for Dart website
https://dart.dev
Other
944 stars 684 forks source link

'Asynchronous programming: futures, async, await' page issue #2198

Closed CheoWalker closed 4 years ago

CheoWalker commented 4 years ago

Page URL: https://dart.dev/codelabs/async-await.html Page source: https://github.com/dart-lang/site-www/tree/master/src/codelabs/async-await.md

Found a typo? You can fix it yourself by going to the page source and clicking the pencil icon. Or finish creating this issue.

Description of issue: It mention code examples that are not found on the page.

kwalrath commented 4 years ago

@CheoWalker could you tell us which code examples it mentions that aren't on the page? Having strings we can search for will help us know how to fix this bug. Thanks!

CheoWalker commented 4 years ago

None of the examples are on the page, just empty code pads.

From: Kathy Walrath notifications@github.com Sent: Monday, January 6, 2020 09:12 PM To: dart-lang/site-www site-www@noreply.github.com Cc: Cheo Walker cwalker@dzwebcreations.com; Mention mention@noreply.github.com Subject: Re: [dart-lang/site-www] 'Asynchronous programming: futures, async, await' page issue (#2198)

@CheoWalker https://github.com/CheoWalker could you tell us which code examples it mentions that aren't on the page? Having strings we can search for will help us know how to fix this bug. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dart-lang/site-www/issues/2198?email_source=notifications&email_token=ABGDYHKUXRP3HWSWEPIAXM3Q4PQFLA5CNFSM4KDPHVM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHOD5A#issuecomment-571400692 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGDYHJG6R4KIFPW36GHFQ3Q4PQFLANCNFSM4KDPHVMQ . https://github.com/notifications/beacon/ABGDYHOIRA2YSJ75TQC7YITQ4PQFLA5CNFSM4KDPHVM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHOD5A.gif

kwalrath commented 4 years ago

Ouch, that sounds like a browser issue. Are you using a browser like Brave that doesn't permit cookies? There's troubleshooting info here: https://dart.dev/tools/dartpad/troubleshoot

CheoWalker commented 4 years ago

Latest version of Chrome.

The following example shows the wrong way to use an asynchronous function (fetchUserOrder()). Later you’ll fix the example using async and await. Before running this example, try to spot the issue – what do you think the output will be? Is string you can target.

From: Kathy Walrath notifications@github.com Sent: Monday, January 6, 2020 09:33 PM To: dart-lang/site-www site-www@noreply.github.com Cc: Cheo Walker cwalker@dzwebcreations.com; Mention mention@noreply.github.com Subject: Re: [dart-lang/site-www] 'Asynchronous programming: futures, async, await' page issue (#2198)

Ouch, that sounds like a browser issue. Are you using a browser like Brave that doesn't permit cookies? There's troubleshooting info here: https://dart.dev/tools/dartpad/troubleshoot

— You are receiving this because you were mentioned. Reply to this email directly, https://github.com/dart-lang/site-www/issues/2198?email_source=notifications&email_token=ABGDYHKHDBIKHWVLJSMJ4TTQ4PSW5A5CNFSM4KDPHVM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHPKYQ#issuecomment-571405666 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/ABGDYHJJ7VT7EJMZEGACHGLQ4PSW5ANCNFSM4KDPHVMQ unsubscribe. https://github.com/notifications/beacon/ABGDYHJX3YKIISLVS2NC3H3Q4PSW5A5CNFSM4KDPHVM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHPKYQ.gif

kwalrath commented 4 years ago

Could you please send us a screenshot and the contents of the JavaScript console?

CheoWalker commented 4 years ago

Here is what I am seeing, I notice the same issue on Flutter.dev as well. I am seeing it in Edge and I even tried turning off my extensions. Annotation 2020-01-07 140811

kwalrath commented 4 years ago

"Failed to read the 'localStorage' property" is an indication that you have cookies turned off. Can you enable cookies in Chrome? The troubleshooting instructions have a link to a page on turning the cookies on (which you'll need to do for dart.dev & flutter.dev): https://support.google.com/chrome/answer/95647

DartPad depends on local storage, so it doesn't work if cookies are disabled. https://github.com/dart-lang/dart-pad/issues/1237 is an issue for improving the UI when this happens.

I'm going to close this issue, since it's a DartPad problem, but I'll see if we can make the dart-pad bug higher than a P3.

CheoWalker commented 4 years ago

Thanks, now I need to figure out my cookies were turned off for dartpad.dev.