Effective dart code example for async/await guideline doesn't follow the guideline about catching exceptions.

[tetkin-g]

In Effective Dart, the guideline about preferring async/await over raw futures includes this as an example of good code:

Future<int> countActivePlayers(String teamName) async {
  try {
    var team = await downloadTeam(teamName);
    if (team == null) return 0;

    var players = await team.roster;
    return players.where((player) => player.isActive).length;
  } catch (e) { // <----
    log.error(e);
    return 0;
  }
}

However it violates the guideline about catches without on clauses.

[munificent]

Good catch. We can fix this by having the example catch some fictitious type that downloadTeam() would theoretically throw, like:

Future<int> countActivePlayers(String teamName) async {
  try {
    var team = await downloadTeam(teamName);
    if (team == null) return 0;

    var players = await team.roster;
    return players.where((player) => player.isActive).length;
  } on DownloadException catch (e) { // <----
    log.error(e);
    return 0;
  }
}