search

dart-lang / source_maps

A package to programmatically manipulate source maps.
https://pub.dev/packages/source_maps
BSD 3-Clause "New" or "Revised" License
16 stars 14 forks source link

Parser bug in source maps #8

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by peter-ahe-google Originally opened as dart-lang/sdk#15124

From issue dart-lang/sdk#14746:

Although I haven't tested it, from looking at the source, I believe there is a similar issue when parsing a sourcemap. Sourcemap entries can have 1, 4, or 5 fields and the 1-field entries (representing an unmapped range) aren't handled correctly; the sourceUrlId, sourceLine, sourceColumn, and fields in a TargetEntry should be set to null but instead they will be set to whatever the values were in the previous TargetEntry.

DartBot commented 9 years ago

Comment by sigmundch

Thanks for opening the bug. I need to take a closer look and re-read the spec on this area, but I think you are correct.

Removed Priority-Unassigned label. Added Priority-Medium, Library-SourceMaps labels.

DartBot commented 9 years ago

Comment by peter-ahe-google

Change the subject, I guess I have mirrors on my mind :-)

Changed the title to: "Parser bug in source maps".

DartBot commented 9 years ago

Comment by sigmundch

It seems that long ago, we run into problems with this code (see https://code.google.com/p/dart/issues/detail?id=11782), and I purposely changed this behavior to incorrectly take the value of the previous entry.

I have a fix locally, but I want to investigate more closely to ensure that we don't regress on the old issues either.

Right now some other things are keeping me busy, so please ping me if you need me to raise the priority on this.

DartBot commented 9 years ago

Comment by anders-sandholm

Removed Library-SourceMaps label. Added Pkg-SourceMaps label.

DartBot commented 9 years ago

Comment by sigmundch

I believe this was fixed by Zarah in dart-lang/sdk@d77b7e50a23d768aeda5dba9e515116fbc1ba088

DartBot commented 9 years ago

Comment by sigmundch

Added Fixed label.