search

dart-lang / test

A library for writing unit tests in Dart.
https://pub.dev/packages/test
490 stars 213 forks source link

Come up with a plan for how to shift the node platform outside of this package #1289

Open natebosch opened 4 years ago

natebosch commented 4 years ago

We want to move away from the Dart team needing expertise on node for our first party tools. One of the biggest dependencies we have on node today is the platform in this package. Ideally we'd like the node platform to be supported outside of the Dart team.

We are blocked by the fact that removing node support is breaking, and we don't have a supported migration path for building back that support outside of the package.

One option might be to finish fleshing out test_core into a stable API and make it possible to define external "runners". With what we have today that might mean some amount of duplication of other stuff in test. Given flutter_test and the hacks that other folks are already doing with src/ imports, this is probably work that we do want to happen at some point anyway.

I think we probably want to steer clear of runtime code injection using isolates etc - the entry point would likely not be pub run test - it may instead be something like pub run node_test.

cc @nex3 for thoughts on how this might look, and whether the Sass team is interested in owned the node platform runner.

nex3 commented 4 years ago

Unfortunately the CSS team's staffing is such that we don't really have the ability to maintain upstream components. However, we do depend heavily on the ability to run tests on Node, so hopefully we can find a way to make this work that won't break us.