dart-lang / web

Lightweight browser API bindings built around JS static interop.
https://pub.dev/packages/web
BSD 3-Clause "New" or "Revised" License
128 stars 22 forks source link

[feat] Adds helpers to convert js lists to a dart list (Resolves #281) #286

Closed rutvik110 closed 1 month ago

rutvik110 commented 1 month ago

[feat] Adds a helpers to convert js list to a dart list (Resolves #281)

Updates:

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
rutvik110 commented 1 month ago

@srujzs

kevmoo commented 1 month ago

Awesome, @rutvik110 – we'll want a changelog entry here, too!

srujzs commented 1 month ago

Thanks for taking this on again, very much appreciated! +1 to changelog entry (especially if we deprecate some of these members). FYI, analysis is complaining about formatting so I'd run dart format on these changes.

It might also be worth adding a test for this (we can just test using the list wrapper for HTMLCollection or something).

rutvik110 commented 1 month ago

@srujzs Changelog added.

srujzs commented 1 month ago

LGTM, let's merge it! The analysis issues are unrelated and I'm working on fixing that.