devoncarew
commented
10 months ago We'd need to coordinate with package:test when rolling this out:
Because test >=1.16.3 <1.16.6 depends on web_socket_channel >=1.0.0 <3.0.0 and test >=1.16.0-nullsafety.8 <1.16.3 depends on web_socket_channel ^1.0.0, test >=1.16.0-nullsafety.8 <1.16.6 requires web_socket_channel >=1.0.0 <3.0.0.
And because test >=1.16.6 depends on web_socket_channel ^2.0.0, test >=1.16.0-nullsafety.8 requires web_socket_channel >=1.0.0 <3.0.0.
So, because web_socket_channel depends on test ^1.16.0 and web_socket_channel is 3.0.0, version solving failed.
This 3.0.0 version is substantially the same as the content from 2.4.1.
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.