dart-lang / web_socket_channel

StreamChannel wrappers for WebSockets.
https://pub.dev/packages/web_socket_channel
BSD 3-Clause "New" or "Revised" License
412 stars 107 forks source link

Make shelf_web_socket a dev dependency #353

Closed brianquinlan closed 2 months ago

brianquinlan commented 2 months ago

Works around this issue:

Hey, I'm trying to release package:web_socket_channel:
dependency_overrides:
  shelf_web_socket:
    git:
      ref: master
      url: https://github.com/dart-lang/shelf.git
      path: pkgs/shelf_web_socket
  test: 1.25.2
package:shelf_web_socket:
dependency_overrides:
  test: 1.25.2
And package:test

When I try to publish web_socket_channel, I get a warning that says: 
* Non-dev dependencies are overridden in pubspec.yaml.

  This indicates you are not testing your package against the same versions of its
  dependencies that users will have when they use it.

  This might be necessary for packages with cyclic dependencies.

  Please be extra careful when publishing.
My intent is to force the head version of shelf_web_socket to be used when running the web_socket_channel unit tests.

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.