dart-lang / webdev

A CLI for Dart web development.
https://pub.dev/packages/webdev
213 stars 71 forks source link

Test checking for DEBUGGER_READY and DEVTOOLS_LOAD events failing #2394

Open elliette opened 3 months ago

elliette commented 3 months ago

In https://github.com/dart-lang/webdev/pull/2388 we switched to connecting to DDS instead of directly to the VMService so that DDS can handle the service extensions.

However, the test checking that the DEBUGGER_READY and DEVTOOLS_LOAD events are sent when DevTools is opened has begun failing. When I launch DevTools to do manually testing, I do see the service extension ext.dwds.sendEvent is correctly being called, and these events are being emitted, so I don't think this is a regression with the feature.

Need to follow-up to figure out what changes are required to get the test to pass again.