dart-lang / webdev

A CLI for Dart web development.
https://pub.dev/packages/webdev
213 stars 71 forks source link

`dart:developer` `log` messages still get truncated in the middle #2400

Closed toineheuvelmans closed 3 months ago

toineheuvelmans commented 3 months ago

https://github.com/dart-lang/webdev/pull/2333 intended to fix truncation of messages logged through log from dart:developer. This fix was shipped with dwds 23.2.0 which was included in webdev 3.4.0.

However, when I run a Flutter project in Chrome, I still get truncated log messages, while using webdev version 3.4.0.

Steps to reproduce

I created a new Flutter project and in main.dart:

import 'dart:developer';

void main() {
    log('1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40');
    log('1 ---------------------------------------'
      '2 ---------------------------------------'
      '3 ---------------------------------------'
      '4 ---------------------------------------'
      '5 ---------------------------------------'
      '6 ---------------------------------------'
      '7 ---------------------------------------'
      '8 ---------------------------------------'
      '9 ---------------------------------------'
      '10 ---------------------------------------');
}

This gave the following log output:

image
flutter doctor -v
[✓] Flutter (Channel stable, 3.19.2, on macOS 14.2.1 23C71 darwin-arm64, locale en-NL)
    • Flutter version 3.19.2 on channel stable at ~/.asdf/installs/flutter/3.19.2-stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7482962148 (4 weeks ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at ~/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = ~/Library/Android/sdk
    • ANDROID_SDK_ROOT = ~/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    …

[✓] Network resources
    • All expected network resources are available.

• No issues found!
elliette commented 3 months ago

webdev is for running non-Flutter web apps, so the DWDS version there doesn't matter.

dwds 23.2.0 is not part of the current Flutter stable, it is on the Flutter beta channel though, and should be in the next Flutter stable.