search

dart-lang / webdev

A CLI for Dart web development.
https://pub.dev/packages/webdev
213 stars 71 forks source link

Rename primary development branch to `main` #2456

Open parlough opened 2 days ago

parlough commented 2 days ago

The dart-lang/webdev repository is one of the few in the dart-lang org that still uses master as its default branch, resulting in an inconsistent contribution experience and not following the org's goals to use more inclusive language where possible.

GitHub has docs on renaming a branch and automatically handles redirects from the old branch name, so no manual forwarding or commit duplication is likely necessary.

bkonyi commented 2 days ago

I agree with this, but I'm a bit nervous about the implications on build infrastructure. Are you aware of any gotchas we might encounter by making this change? Otherwise, it might be best to wait this out since there's a good chance we'll be moving this repo into the Dart SDK in the future.

parlough commented 2 days ago

Are you aware of any gotchas we might encounter by making this change?

Not that I know of based of similar updates in the dart-lang and flutter org, as long as we update the various GitHub actions files to work on main and master before making the change.

I'm not sure of the usage in google3, but if it uses the version of this repo in the SDK DEPS, I suppose there should be no concerns there either, as that will be updated to a commit ref.

If you are worried, Google has a mirroring GitHub action that we could use to temporarily mirror commits to the master branch. flutter/flutter has it setup for the opposite direction in https://github.com/flutter/flutter/blob/master/.github/workflows/mirror.yml.

\cc @devoncarew

devoncarew commented 2 days ago

We've done this for ~a dozen repos; it's relatively low impact on people's checkouts and such and worth doing. Here's the steps we've followed:

https://github.com/dart-lang/ecosystem/wiki/Renaming-master-branches-to-main

bkonyi commented 1 day ago

Sounds good, I'll start the process then!

bkonyi commented 1 day ago

@devoncarew, I don't have permission to rename the branch. Since the Developer Services team is taking over this repo, could you give me (and maybe @derekxu16?) admin permissions?