search

dart-lang / webdev

A CLI for Dart web development.
https://pub.dev/packages/webdev
212 stars 71 forks source link

Updating test expectations for DDC Set implementations. #2458

Closed Markzipan closed 1 week ago

Markzipan commented 1 week ago

DDC Sets Impls are now in dart:_js_helper (like with Maps) instead of dart:collection.

jakemac53 commented 1 week ago

Note that this PR introduced a new CI failure (during analysis, as there is now an unused variable).

jakemac53 commented 1 week ago

In general, when merging on red we should provide an explanation, and if there is a known failure then an issue should be filed to resolve it, or possibly skip the test etc, so that new failures like this aren't missed.

bkonyi commented 1 week ago

In general, when merging on red we should provide an explanation, and if there is a known failure then an issue should be filed to resolve it, or possibly skip the test etc, so that new failures like this aren't missed.

That's my bad, I somehow missed that there was a failure and hit merge... I'll fix this now.