Use var/final consistently across repository

dart-lang / webdev

A CLI for Dart web development.

https://pub.dev/packages/webdev

212 stars 75 forks source link

Use var/final consistently across repository #2502

Closed parlough closed 1 month ago

parlough commented 1 month ago

Before this change, only dwds was set up to prefer final, while the other projects used an inconsistent mix of var and final. This PR pulls the declaration of prefer_final_locals out to the shared analysis_options.yaml, adds prefer_final_in_for_each as well, and applies the fixes across the repository.

This will help reduce the question of which keyword to use when working in this repository.

auto-submit[bot] commented 1 month ago

auto label is removed for dart-lang/webdev/2502, due to This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit[bot] commented 1 month ago

auto label is removed for dart-lang/webdev/2502, due to - The status or check suite Maybe prevent submission has failed. Please fix the issues identified (or deflake) before re-applying this label.