dart-lang / yaml

A Dart YAML parser.
https://pub.dev/packages/yaml
MIT License
169 stars 58 forks source link

Offset issue appearing in an analysis_options.yaml file #89

Closed jwren closed 3 years ago

jwren commented 3 years ago

Offset issue appearing in 2020.2 EAP version of IJ:

Screen Shot 2020-09-21 at 1 24 10 PM

bwilkerson commented 3 years ago

My guess is that the offset of the span for include ignores the fact that there are comments before it.

jwren commented 3 years ago

The integer offset seems to be coming out of https://github.com/dart-lang/yaml

@kevmoo do you know who owns yaml?

kevmoo commented 3 years ago

Currently undefined, sadly.

bwilkerson commented 3 years ago

I looked at the parser and didn't see any obvious problem, so I looked at the analyzer's use of the parser and believe that I have found the problem (https://dart-review.googlesource.com/c/sdk/+/165980). The issue isn't in the parser, so I'm closing this issue.