search

dart-lang / yaml_edit

A library for YAML manipulation with comment and whitespace preservation.
https://pub.dev/packages/yaml_edit
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

Fix for issue #23 #34

Closed Ishad-M-I-M closed 1 year ago

Ishad-M-I-M commented 1 year ago

The nextNewLineIndex is calculated incorrectly in _appendToBlockList function Fixes #23

jonasfj commented 1 year ago

Also, if you write:

Fixes #23

In the pull request description, then it'll be linked to the issue, and the issue will be closed when this pull-request is landed.

It might also be nice to make a few more tests to help demonstrates that we're not introducing any new issues with this change :D

There most likely is variations of list append we haven't got good tests cases for.

jonasfj commented 1 year ago

@Ishad-M-I-M if I forget, feel free to @jonasfj ping me; I'd love to get this landed. Once test pass and ideally we have few more test cases.

Ishad-M-I-M commented 1 year ago

@jonasfj added one testcase for each appendToList and insertToList.