search

dart-lang / yaml_edit

A library for YAML manipulation with comment and whitespace preservation.
https://pub.dev/packages/yaml_edit
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

Fix line endings for inserted maps on Windows #66

Closed DanTup closed 8 months ago

DanTup commented 8 months ago

Replaces a hard-coded \n to instead use the correct line-ending for the document.

This fixes an issue where documents on Windows using \r\n could end up with mismatched newlines.

@kevmoo I bumped the version and added to changelog, but not sure what the process is (and there's no contributing file here).

Fixes https://github.com/dart-lang/yaml_edit/issues/65

DanTup commented 8 months ago

Sure, this isn't urgent (I landed a workaround in the analysis server in the meantime).

I also can't merge here, so you might need to merge it anyway :-)

Let me know if you need me to rebase it or anything (I don't entirely understand the change #67 is making :-) )

devoncarew commented 8 months ago

@DanTup - can you merge main into this PR, just to get the bots to process it again?

DanTup commented 8 months ago

@devoncarew I've rebased on main, but you'll need to re-approve the bots :)

github-actions[bot] commented 8 months ago

Package publishing

Package Version Status Publish tag (post-merge)
package:yaml_edit 2.2.0 ready to publish v2.2.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

DanTup commented 8 months ago

https://github.com/dart-lang/ecosystem/wiki/Publishing-automation

Oh, I see - that's neat :-)

kevmoo commented 8 months ago

https://github.com/dart-lang/ecosystem/wiki/Publishing-automation

Oh, I see - that's neat :-)

RIGHT?!?!

DanTup commented 8 months ago

Someone else will need to land this if/when you're happy with it, I have no powers here :-)