Noticed that we never set yamlWarningCallback when parsing YAML internally, this meant that the terminal would show warnings.
This is sad, because some of the internal stuff really only used loadYamlNode to determine if a string needed to be quoted, or if the edits were sane -- so warnings aren't actually intended for the end-user.
One could argue that we should avoid edits that produce warnings, but that seems to an orthogonal concern, this really just stops warnings produces internally from polluting stdout.
Noticed that we never set
yamlWarningCallbackwhen parsing YAML internally, this meant that the terminal would show warnings.This is sad, because some of the internal stuff really only used
loadYamlNodeto determine if a string needed to be quoted, or if the edits were sane -- so warnings aren't actually intended for the end-user.One could argue that we should avoid edits that produce warnings, but that seems to an orthogonal concern, this really just stops warnings produces internally from polluting stdout.