search

dart-lang / yaml_edit

A library for YAML manipulation with comment and whitespace preservation.
https://pub.dev/packages/yaml_edit
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

Fix splice list insertion #84

Closed kekavc24 closed 5 months ago

kekavc24 commented 5 months ago

This PR:

@jonasfj Everything works fine and as expected. However, there is a test in randomTest.dart that fails because the string generated is invalid and is never parsed correctly from the start.

It's the only test failing.

Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
jonasfj commented 5 months ago

@jonasfj Everything works fine and as expected. However, there is a test in randomTest.dart that fails because the string generated is invalid and is never parsed correctly from the start.

Can we change it such that it doesn't generate invalid cases?

We need to either skip or fix tests, if they are unrelated to this issue, I don't mind skipping and filing an issue to fix them separately.

kekavc24 commented 5 months ago

@jonasfj Everything works fine and as expected. However, there is a test in randomTest.dart that fails because the string generated is invalid and is never parsed correctly from the start.

Can we change it such that it doesn't generate invalid cases?

We need to either skip or fix tests, if they are unrelated to this issue, I don't mind skipping and filing an issue to fix them separately.

It's the 20th iteration. Same random string (doesn't feel random) each time. An issue will be fine. I've skipped it for now. I can tackle it separately. I had to modify the Generator class slightly to get the current iteration.

jonasfj commented 5 months ago

@kekavc24 by the way, feel free to file a PR with a new bullet point for the CHANGELOG.md. it might be nice for package consumers to know what we fixed :D