dart-ogurets / Ogurets

Dart support for Gherkin
BSD 2-Clause "Simplified" License
10 stars 6 forks source link

Replace deprecated mirrors package with generated code #22

Open BenVercammen opened 2 years ago

BenVercammen commented 2 years ago

As noted in the `README file:

The Dart Authors have indicated that Dart::Mirrors is obsolete and will be removed. This is causing grief for many projects and will cause grief for this project as well as it used runtime checking to find your methods. We will be moving to a 5.x version which will require code generation to resolve the issue as we use Ogurets heavily in our testing at FeatureHub.IO (https://featurehub.io)

BenVercammen commented 2 years ago

So what would be the plan?

@rvowles If you need any help on this, I might be able to look into the code generator part, as I've already got some experience working with analyzer, build, code_builder packages. I'm also fluent in Java, but don't have any experience with IntelliJ plugins yet...

rvowles commented 2 years ago

I haven't really thought about it to be honest. I don't think there is any problem running the dart generator from the IDEA plugin, it would seem a better choice to be consistent and have all the code in one place. I'm totally open to any suggestions or PRs.