search

dartclub / turf_dart

A turf.js-like geospatial analysis library working with GeoJSON, written in pure Dart.
https://pub.dev/packages/turf
MIT License
63 stars 29 forks source link

Match booleanEqual's parameters to that of turf_equality #117

Closed armantorkzaban closed 2 years ago

armantorkzaban commented 2 years ago

the function uses the Equality in its core, but does not pass the adequate arguments into the class. This results in limited tests for equality, in cases where 'shifting positions' or 'reverse direction' has to be taken into account for the two objects being compared. What do you think @lukas-h

lukas-h commented 2 years ago

I agree, that we should adjust the interface of booleanEquals to the turf_equality interface. Go ahead with it.

But an overarching topic is: I'm generally unsure what would be the right strategy to combine turf_equality (geojson-equality port), the booleanEquals, and on the == override #45, my comment on that one explains it further: https://github.com/dartclub/turf_dart/issues/45#issuecomment-1167109338

armantorkzaban commented 2 years ago

https://github.com/dartclub/turf_dart/pull/91/commits/5c863e05f5882b040bd4001a83cd096c7a3bacee