search

dartclub / turf_dart

A turf.js-like geospatial analysis library working with GeoJSON, written in pure Dart.
https://pub.dev/packages/turf
MIT License
63 stars 29 forks source link

Port boolean functions and tests #91

Closed armantorkzaban closed 1 year ago

armantorkzaban commented 2 years ago

https://github.com/dartclub/turf_dart/issues/88

armantorkzaban commented 2 years ago

Hi, please don't forget to add the api interface file (lib/rhumb_bearing.dart)

Or will we link it in the lib/bearing.dart file?

wdyt @armantorkzaban

I would say we make the bearing functions available through one interface.

lukas-h commented 1 year ago

Hi @armantorkzaban, where are we here?

armantorkzaban commented 1 year ago

I am going to work on Booleans libraries around the evening of 23.08. Will be able to give an assessment of the situation and an implementation timeline on 24th.

armantorkzaban commented 1 year ago

Nothing much is left here! A quick clean-up tomorrow and we are done with Booleans and many things will be Confetti!

lukas-h commented 1 year ago

that is awesome news 👍

lukas-h commented 1 year ago

please go through the conversations and see if everything is done there

armantorkzaban commented 1 year ago

none of the touched files in 29dd77b are ready or tested fully. Just the basic implementation is there and there changes needed to be made. We need more time than expected because of the rbush and where it is used, the line_overlap.dart(-> boolan_overlap).

lukas-h commented 1 year ago

I will give another full review, once the comments from the last review have been worked on!

armantorkzaban commented 1 year ago

I will give another full review, once the comments from the last review have been worked on!

Cannot see them and they have not showed up in the notifications yet!