Image fixes - Githubissues

darthbatman / billboard-top-100

:chart_with_upwards_trend: Node.js API to retrieve the top songs, albums, and artists from Billboard's charts

MIT License

97 stars 30 forks source link

Closed gabe0x02 closed 4 years ago

gabe0x02 commented 4 years ago

Hey great job with the update. Found a few remaining issues and was able to put together another PR. This time with tests passing.

Small refactor to pull chart-data using cheerio. (a small bit faster too)
Fixed hosts for image url host.
Fixed issues when original image was not available.
Fixed issue with no sizes / placeholder image url
- different host from normal images
- path in data was just not correct (small hack to correct it)
Tests for fixes

darthbatman commented 4 years ago

Thank you for the fixes!

darthbatman commented 4 years ago

Changes reflected in v2.5.5