search

darthbatman / billboard-top-100

:chart_with_upwards_trend: Node.js API to retrieve the top songs, albums, and artists from Billboard's charts
MIT License
97 stars 30 forks source link

Billboard site update fixes #39

Closed nechemiaseif closed 4 years ago

nechemiaseif commented 4 years ago

The recent changes to this package fixed the issues with the Hot 100 and Billboard 200 charts, but did not fix functionality for most other charts, e.g. latin-songs, rock-songs, etc.

This pull request fixes these problems, so the package can flexibly scrape whichever type of chart is requested.

codecov-io commented 4 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.31%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   82.85%   83.16%   +0.31%     
==========================================
  Files           1        1              
  Lines          70      101      +31     
==========================================
+ Hits           58       84      +26     
- Misses         12       17       +5
Impacted Files Coverage Δ
billboard-top-100.js 83.16% <87.5%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84351f5...b52f1e7. Read the comment docs.

nechemiaseif commented 4 years ago

@darthbatman Please take a look

darthbatman commented 4 years ago

Changes reflected in v2.5.6