darthcloud / BlueRetro

Multiplayer Bluetooth controllers adapter for retro video game consoles

https://blueretro.io

Apache License 2.0

1.23k stars 103 forks source link

Fix 8bitdo Neo Geo Shoulder buttons #942

Closed GrumpyGopher closed 2 months ago

GrumpyGopher commented 3 months ago

933 Fix issue with 8bitdo NeoGeo pad shoulder buttons not detected. The 8bitdo Neo Geo Pad is most like the 8BitDo SNES pads with just L1 and R1 shoulder buttons. In version 1.8.4 this line didn't exist at all and it just defaulted to default 8bitdo settings. Compiled this locally and tested and it seemed to fix the problem.

darthcloud commented 2 months ago

See #933 while this PR worked to get the trigger as L1/R1 my original objective was to have them on L2/R2 by default.

That is now working in latest beta.

Thanks for the PR in anycase!

GrumpyGopher commented 2 months ago

Cool I'll give it a try sometime. A little curious why you wanted them defaulted to L2/R2 when they are digital buttons and they are even labeled L and R just like L1 and R1 on the 8bitdo SN30Pro+ controllers?

darthcloud commented 2 months ago

the main trigger are In BlueRetro are L2,R2 or LT, RT, or ZL,ZR the top one are the secondary. This keeps things consistent across all systems.