search

darthdeus / comfy

Comfy is a fun 2D game engine built in Rust. It's designed to be opinionated, productive, and easy to use.
https://comfyengine.org
Apache License 2.0
678 stars 28 forks source link

feature: add wayland support #54

Closed RobWalt closed 9 months ago

RobWalt commented 9 months ago

This resolves #51

I'm not sure if I should also update the Cargo.lock in the repo, but I guess it's ok not to do it.

Btw: Isn't the standard way of doing things in rust not shipping the Cargo.lock with library crates anyways?

darthdeus commented 9 months ago

Thanks for the PR.

I'm not entirely sure about the lockfile. The lock file is for the workspace and not the individual crates, which are published separately, so it shouldn't affect consumers from crates.io? I'm not sure what's a downside to having a lock file on the workspace as a whole.

RobWalt commented 9 months ago

@darthdeus

I think there is no real downside to this. People working on the repo with different feature flags (x11/wayland) are probably just gonna overwrite the Cargo.lock back and forth.

But since you're probably also working on unpublished executable crates in that workspace it's just fine :+1: