search

dartist / dart-bignum

Other
14 stars 11 forks source link

BigInteger.intValue() gives wrong values #32

Open stevenroose opened 9 years ago

stevenroose commented 9 years ago

In #30 I already mentioned that intValue returns positive values for negative BigIntegers.

I've been using the method a little more, and the results are staggering, so to say.

print(new BigInteger("5000000000").intValue()); // 705032704
print(new BigInteger("705032704").intValue());  // 705032704
print(new BigInteger("7050327040").intValue()); // 2755359744
print(new BigInteger("4755359744").intValue()); // 460392448

JS does not support large integers, so for JS, strange results for large numbers would be no surprise, but these are in the Dart VM.

Since many people already rely on this package, this must be fixed soon. I'd suggest maybe to completely change the implementation, to something more generic like BigInt from the decimal package: https://github.com/a14n/dart-rational/blob/master/lib/bigint.dart

adam-singer commented 9 years ago

@stevenroose I do not have time now to maintain this package. IIRC dart team was working on a big num implementation, not sure if it has landed yet.