Closed stevenroose closed 8 years ago
Thanks! I wonder if @financeCoding might be open to transferring the repo over to you?
@sethladd @financeCoding @rinick I recently contacted @izaera, the original cipher author and he will no longer maintain the library. So we decided, in an attempt to revitalize the Cryptography for Dart initiative, to rename it.
I just launched https://github.com/PointyCastle/pointycastle. I would be willing to bring bignum onto the organisation and add you as co-maintainers. I guess cipher/Pointy Castle is the largest user of the bignum package anyways.
@kaendfinger can you take a look at this one, too?
@sethladd Sure, I'll take a look
A change I didn't dare to make was remove this class: https://github.com/dartist/dart-bignum/blob/master/lib/src/BigInteger/big_integer.dart
It is never used, so it seems to be there for no reason.
I think after that class being removed, it would be best to bump this project to 0.1.0 because (even though I doubt if any) people relying on the individual implementations would see a breaking change.
PS, while your're at it, perhaps remove the "Under construction" notice from the README :)
And @financeCoding the idea of moving this repo in the Pointy Castle project is still open.
Thanks for reminding me, about this. I'll make a separate commit later to do the readme change :)
I cleaned up the interface so that the concrete implementations are no longer exposed, and I also hided the
useJsBigint
variable because it is irrelevant to the user.