dartist / redis_client

A high-performance async/non-blocking Redis client for Dart
BSD 2-Clause "Simplified" License
100 stars 29 forks source link

M1 update needs testing #3

Closed adam-singer closed 11 years ago

adam-singer commented 11 years ago

This takes care of most of the obvious stuff. Now running into problems with the switch out of SocketInputStream for InputStream. SocketInputStream now hangs off of Socket.input as an InputStream. When trying to set onData. Something with the actual test implementation fails if you remove the onData setting, I assume that would create other problems in general.

Do you have any time to look at this? I'm trying to get a project updated that does depend on this library dart-share

Unhandled exception:
StreamException: Cannot set data handler when input stream is used
#0      _Socket.onData= (dart:io-patch:716:37)
#1      _RedisConnection.ensureConnected (package:dartredisclient/src/RedisConnection.dart:180:13)
#2      _RedisConnection.sendCommand (package:dartredisclient/src/RedisConnection.dart:211:20)
#3      _RedisConnection.sendExpectSuccess (package:dartredisclient/src/RedisConnection.dart:287:16)
#4      _RedisNativeClient.flushall (package:dartredisclient/src/RedisNativeClient.dart:178:46)
#5      RedisClientTests.<anonymous closure> (file:///Users/adam/dart/DartRedisClient/test/RedisClientTests.dart:16:26)
#6      runAllTests.<anonymous closure> (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:148:16)
#7      runAllTests.<anonymous closure> (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:158:5)
#8      runAllTests.<anonymous closure>.<anonymous closure> (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:141:12)
#9      start (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:59:18)
#10     runAllTests.<anonymous closure> (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:159:30)
#11     runAllTests (file:///Users/adam/dart/DartRedisClient/test/DUnit.dart:162:8)
#12     main (file:///Users/adam/dart/DartRedisClient/test/TestSuite.dart:14:14)
mythz commented 11 years ago

Cool thx.

Yep cool I'll have a look and try to fix any failing unit tests on the weekend.