search

dartist / redis_client

A high-performance async/non-blocking Redis client for Dart
BSD 2-Clause "Simplified" License
100 stars 29 forks source link

fix unsubscribe in pubsub #45

Closed tomaszkubacki closed 10 years ago

tomaszkubacki commented 10 years ago

fixed unsubscribe, added test

bbss commented 10 years ago

Thanks

tomaszkubacki commented 10 years ago

@bbss thank you for merging :) I will modify readme to show pubsub if you don't mind.

bbss commented 10 years ago

Yeah sure, try adding the pubsub tests to the all_tests if you don't mind?

tomaszkubacki commented 10 years ago

@bbss sure done - BTW this https://gist.github.com/tomaszkubacki/8783531 is what I get if I do not turn off redis_client_tests.dart in all_tests.dart

bbss commented 10 years ago

Yeah, I remember changing that a while back to match behavior of my Redis-cli but now I wonder what is the right behavior. But is that the only thing that errors for you? Try commenting out that test. More tests in there broke for me on osx + redis 2.8.4.

tomaszkubacki commented 10 years ago

hi,

If I turn off INCRBYFLOAT test, then tests do not throw but are freezing and still can't find which test is locking. Will drop you an email if I find something

2014-02-03 Baruch Berger notifications@github.com:

Yeah, I remember changing that a while back to match behavior of my Redis-cli but now I wonder what is the right behavior. But is that the only thing that errors for you? Try commenting out that test. More tests in there broke for me on osx + redis 2.8.4.

— Reply to this email directly or view it on GitHubhttps://github.com/dartist/redis_client/pull/45#issuecomment-33953668 .