dartist / redis_client

A high-performance async/non-blocking Redis client for Dart
BSD 2-Clause "Simplified" License
100 stars 29 forks source link

Refactoring #7

Closed enyo closed 11 years ago

enyo commented 11 years ago

Hi,

I started refactoring RedisClient for the current dart version but the changes are a bit bigger.

I hope to be done by tomorrow.

Just wanted to let you know ;)

mythz commented 11 years ago

Matias this is great to hear and v. appreciated! The switch to the new IO model will likely make this a non-trivial effort, so don't be surprised if it takes more than 1 day :)

FYI: I just talked it over with @financeCoding and we're delighted to welcome you as a admin contributor on the Dartist org - so you should now be able to commit directly to any of the Dartist projects (lemme know if this isn't the case - you might need to re-clone). You can still use pull-requests if you want to talk over any large/design changes, but otherwise for straight-forward changes you can commit directly to the repo.

Also as the name suggests we want Dartist to be an org for Dart-specific quality projects, so if you wish, feel free to create any new Dart repos/projects you want to add.

enyo commented 11 years ago

Hi @mythz ! Thanks for making me an admin for Dartist.

I opened the invitation on my phone, and wanted to zoom into the team members, but my double tap has been interpreted as single tap and I accidently deleted the third member. I suppose it was @financeCoding since he's the other active commiter and you mentioned him here, so I just added him back.

I'm sorry for my immediate display of clumsiness :)

I'll push my changes directly to the repos tomorrow then.

Have a nice day!

mythz commented 11 years ago

Yep just checked, and @financeCoding is still a member so all is good :)

Looking forward to your updates, I've been meaning to update RedisClient to the new IO Streams model for quite a while now, but haven't found the time - so your efforts here are very welcomed!

adam-singer commented 11 years ago

Nice!