search

dartoos-dev / eo_color

An elegant, object-oriented implementation of the Material Design color palettes and swatches.
MIT License
7 stars 2 forks source link

refactor: fix incorrect use of greater for index #56

Closed rafamizes closed 3 years ago

rafamizes commented 3 years ago

The proper comparative for index is higher, not greater.

Closes #55

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 (dc80e35) into master (1f666d9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines          271       271           
=========================================
  Hits           271       271
Impacted Files Coverage Δ
lib/src/material/amber/amber_accents.dart 100.00% <ø> (ø)
lib/src/material/amber/ambers.dart 100.00% <ø> (ø)
lib/src/material/blue/blue_accents.dart 100.00% <ø> (ø)
lib/src/material/blue/blues.dart 100.00% <ø> (ø)
lib/src/material/blue_grey/blue_greys.dart 100.00% <ø> (ø)
lib/src/material/brown/browns.dart 100.00% <ø> (ø)
lib/src/material/cyan/cyan_accents.dart 100.00% <ø> (ø)
lib/src/material/cyan/cyans.dart 100.00% <ø> (ø)
.../src/material/deep_orange/deep_orange_accents.dart 100.00% <ø> (ø)
lib/src/material/deep_orange/deep_oranges.dart 100.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f666d9...dc80e35. Read the comment docs.

rafamizes commented 3 years ago

@rultor good to merge.

rultor commented 3 years ago

@rultor good to merge.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor good to merge.

@rafamizes Done! FYI, the full log is here (took me 3min)

rafamizes commented 3 years ago

@rultor release, tag is 0.0.9.

rultor commented 3 years ago

@rultor release, tag is 0.0.9.

@rafamizes OK, I will release it now. Please check the progress here

rultor commented 3 years ago

@rultor release, tag is 0.0.9.

@rafamizes Done! FYI, the full log is here (took me 2min)

rafamizes commented 3 years ago

Merged and released by Rultor.