`Cannot read properties of null (reading 'path')` when selecting a note set

dartungar / obsidian-simple-note-review

Simple, customizable plugin for easy note review, resurfacing & repetition in Obsidian.md.

MIT License

57 stars 2 forks source link

`Cannot read properties of null (reading 'path')` when selecting a note set #12

Closed stefanherzog closed 1 year ago

stefanherzog commented 1 year ago

Hi! Since I upgraded to Obsidian 1.0.0 I'm getting the error

Cannot read properties of null (reading `path`)

when I select a note set. Two days ago I somehow got it back to work (I've re-installed your plugin and did tried some other things), but I couldn't say what it was. The error message sounds like it's a problem with dataview(js). Any ideas what this is about?

dartungar commented 1 year ago

Thanks for the report! I've reproduced it, will look into it as soon as possible since it's pretty nasty.

stefanherzog commented 1 year ago

Thanks! One weird insight: When I got the error, one thing that seemed to fix it was to ask the spaced repetition plugin (which I'm also using) to review the next note. Then going back to your plugin, asking for the next note worked fine. I think I've reproduced this twice, not sure what it means.

dartungar commented 1 year ago

Yeah, this bug is weird. After that one time I can not reproduce it, no matter what I do! I have some ideas about the cause, and I will try to remedy them. If you happen to discover a stable way to reproduce this bug, please post it here!

kmaustral commented 1 year ago

I'm getting this error now too. I don't know what caused it.

efemkay commented 1 year ago

just dropping a note that i also faced with this issue.

dartungar commented 1 year ago

@efemkay @kmaustral So far I wasn't able to reproduce this error. It would help if you provide specifics of the note set you are having trouble with: does it use folders, tags, or both? A screenshot would do just fine, like that:

dartungar commented 1 year ago

https://github.com/dartungar/obsidian-simple-note-review/releases/tag/0.5.9 should help with this error, but please provide the screens anyway!

efemkay commented 1 year ago

awesome! the latest update fixed that. anyhow, below is the plugin settings (for both before and after the update), which the update fixed the issue. fyi, i intend to review my notes with #PermanentNote but i added any notes from folder "Areas" just widen the coverage (in case that is an issue)

dartungar commented 1 year ago

Okay, I've reproduced this bug in one case:

open note set
delete the note
try to open any note set again The bug is probably due to Dataview unable to get current note's path (since it is deleted), I will look into how to fix that properly.

dartungar commented 1 year ago

Hopefully, this is fixed in v0.5.10.