search

dartungar / obsidian-simple-note-review

Simple, customizable plugin for easy note review, resurfacing & repetition in Obsidian.md.
MIT License
62 stars 2 forks source link

Show warning if noteset settings are incorrect / Highlight errors in Noteset settings #35

Closed andreykp closed 1 year ago

andreykp commented 1 year ago

To reproduce: place multiply tags in settings, using new line as delimiter, without comma try to open "next note to review"

plug-in will not do anything. It will look as just broken.

I think there should be notification or error shown

andreykp commented 1 year ago

I think the related code is here: https://github.com/dartungar/obsidian-simple-note-review/blob/master/src/settings/settingsTab.ts#L148

dartungar commented 1 year ago

@andreykp the plugin does not indicate if user makes a mistake in noteset configuration - am I understanding this correctly?

andreykp commented 1 year ago

@andreykp the plugin does not indicate if user makes a mistake in noteset configuration - am I understanding this correctly?

Yes. Highlight error. Or I can suggest to turn CRLF into comma, but it will be more code.

dartungar commented 1 year ago

@andreykp I see; I will probably implement simple warnings if noteset looks empty or query has error some time soon!

dartungar commented 1 year ago

Implemented some noteset rules validation in v1.2.0.