search

dartungar / obsidian-simple-note-review

Simple, customizable plugin for easy note review, resurfacing & repetition in Obsidian.md.
MIT License
57 stars 2 forks source link

Lethal Type Error, Everything Seems Broken #49

Closed wagle closed 9 months ago

wagle commented 9 months ago

Obsidian Version 1.4.16 (Installer 1.4.13)

regression looks like it came in with last week's mods?

Screenshot 2023-11-20 at 2 51 56 AM
wagle commented 9 months ago

At one point, your dataviewjs query for "(#tagName) OR (topLevelFolderName)" failed because it didn't like the syntax of "(topLevelFolderName)" for some reason:

Screenshot 2023-11-20 at 3 20 39 AM
dartungar commented 9 months ago

@wagle hi there! Thanks for the report!

  1. This is an issue - I will fix that. In the meantime, please reset the queue before you start the first review.
  2. The folder name should be in quotes - is it so in your case? If it is, please post the screenshot of your note set settings so I can troubleshoot.
wagle commented 9 months ago
  1. Today I had no quotes, I thought I had tried that, but maybe hadn't tried the other things. After fixing quote, and a number of other things, it seems to be working now
dartungar commented 9 months ago

@wagle nice! are there "everything is broken" errors now?

wagle commented 9 months ago

not seeing that error, but its not seeing anything in the queue at the moment would try harder, but ran out of ideas

it does this a bit:

Screenshot 2023-12-03 at 9 49 37 PM
dartungar commented 9 months ago

@wagle it's really really hard to say what causes this problem without having your vault at hand. Hopefully new 1.2.0 version with validation will help.

I'm closing this issue; if you encounter this bug again, please make sure to provide more info, such as:

Cheers!

wagle commented 9 months ago

It’s now reported that my note set had validation errors (which would explain things), but it doesn’t say what?

On Dec 6, 2023, at 8:51 AM, Danila Nikolaev @.***> wrote:

@wagle https://github.com/wagle it's really really hard to say what causes this problem without having your vault at hand. Hopefully new 1.2.0 version with validation will help.

I'm closing this issue; if you encounter this bug again, please make sure to provide more info, such as:

noteset settings (at least screenshot) some info about your notes, since I need some way of knowing if noteset settings/rules should indeed match any notes in your vault Cheers!

— Reply to this email directly, view it on GitHub https://github.com/dartungar/obsidian-simple-note-review/issues/49#issuecomment-1843281192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGIDFCB7T5EHDXD7SNMNLYICO7ZAVCNFSM6AAAAAA7SWXT6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGI4DCMJZGI. You are receiving this because you were mentioned.

wagle commented 9 months ago

Should I wait for more informative error messages, or send it more details?

On Dec 6, 2023, at 9:05 AM, Perry Wagle @.***> wrote:

It’s now reported that my note set had validation errors (which would explain things), but it doesn’t say what?

On Dec 6, 2023, at 8:51 AM, Danila Nikolaev @.***> wrote:

@wagle https://github.com/wagle it's really really hard to say what causes this problem without having your vault at hand. Hopefully new 1.2.0 version with validation will help.

I'm closing this issue; if you encounter this bug again, please make sure to provide more info, such as:

noteset settings (at least screenshot) some info about your notes, since I need some way of knowing if noteset settings/rules should indeed match any notes in your vault Cheers!

— Reply to this email directly, view it on GitHub https://github.com/dartungar/obsidian-simple-note-review/issues/49#issuecomment-1843281192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGIDFCB7T5EHDXD7SNMNLYICO7ZAVCNFSM6AAAAAA7SWXT6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGI4DCMJZGI. You are receiving this because you were mentioned.