search

darukjs / daruk

a node.js web framework based on typescript
http://darukjs.com
MIT License
935 stars 79 forks source link

feat: @header #40

Closed zhmushan closed 5 years ago

zhmushan commented 5 years ago

29

codecov[bot] commented 5 years ago

Codecov Report

Merging #40 into developer will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           developer      #40      +/-   ##
=============================================
+ Coverage      96.61%   96.66%   +0.04%     
=============================================
  Files             27       27              
  Lines            650      659       +9     
  Branches          45       45              
=============================================
+ Hits             628      637       +9     
  Misses            17       17              
  Partials           5        5
Impacted Files Coverage Δ
src/decorators/response.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e4304d...3eece2e. Read the comment docs.

zhmushan commented 5 years ago

@Himself65 done.

zhmushan commented 5 years ago

(题外话: 我第一次为一个 pr 用 rebase, 所以花了点时间, 好奇为啥不用 GitHub 提供的 rebase and merge 那个按钮

xiaojue commented 5 years ago

(题外话: 我第一次为一个 pr 用 rebase, 所以花了点时间, 好奇为啥不用 GitHub 提供的 rebase and merge 那个按钮

(题外话: 我第一次为一个 pr 用 rebase, 所以花了点时间, 好奇为啥不用 GitHub 提供的 rebase and merge 那个按钮

哈哈哈 我这边可以选的

himself65 commented 5 years ago

rebase的事情自己搞，不然对方还得思考怎么给你写commit message 还有其他git可能没有自动rebase功能