search

darul75 / angular-awesome-slider

:arrows_clockwise: Angular slider control directive
http://darul75.github.io/angular-awesome-slider/
MIT License
144 stars 63 forks source link

Add show or hide Labels #103

Closed R0dgerV closed 9 years ago

darul75 commented 9 years ago

great good idea thx for providing this PR

darul75 commented 9 years ago

I have renamed option to 'limits'

R0dgerV commented 9 years ago

Ок. no problem! )))))

darul75 commented 9 years ago

options was there but not yet implemented...;)

R0dgerV commented 9 years ago

i modify locale code 

          scope.options.limits = scope.options.limits || true;

to

if (angular.isDefined(scope.options.limits)) {
   scope.options.limits = true;
} else
{
   scope.options.limits = false;
}

because scope.options.limits always true

darul75 commented 9 years ago

how can it be always true ?

R0dgerV commented 9 years ago

If I'm not mistaken,

scope.options.limits = scope.options.limits || true; = bool(scope.options.limits) === false;

But I could be wrong!

I always true

darul75 commented 9 years ago

my mistake..