search

darul75 / angular-awesome-slider

:arrows_clockwise: Angular slider control directive
http://darul75.github.io/angular-awesome-slider/
MIT License
144 stars 63 forks source link

Change the "ng" prefix to something else #15

Closed mkhanal closed 9 years ago

mkhanal commented 10 years ago

'ng' is reserved for official angular components. I stumbled upon this assuming it is from angular team. While I still would use it, I would like it to have some other prefix and not 'ng'

darul75 commented 10 years ago

What do you suggest ? just 'slider'.

I have seen many comments about this subject for different custom directives but 'ng' prefix is so meaningful...

mkhanal commented 10 years ago

anything else actually, even darul-slider is good...just to avoid name clash. I have been working with some directives around slider as well and will choose a different prefix. Definitely want to have different namespaces to avoid clashes.

ghost commented 9 years ago

They provide a suggestion for internal directives (x-ng) to avoid confusion, but for third-party directives you should come up with your own prefix. Nevertheless, I would have tried this out but it just crashes applications (yes, have all the dependencies included, and everything works fine except when adding your fork).

kanagukrs commented 9 years ago

my suggestion would be awesome-range-slider or ar-slider (ar - awesome range)

darul75 commented 9 years ago

I like @kanagukrs your suggestions, I will do it soon, it sounds great and awesome ;)

kanagukrs commented 9 years ago

It would be fine if you change the directive name from slider to angular-awesome-slider, right now, you only changed the module and file names

darul75 commented 9 years ago

ok, I hesitate as it was a bit long name, I will do