Monitor changes with ngModel

darul75 / angular-awesome-slider

:arrows_clockwise: Angular slider control directive

http://darul75.github.io/angular-awesome-slider/

MIT License

144 stars 63 forks source link

Monitor changes with ngModel #20

Closed mbukosky closed 10 years ago

mbukosky commented 10 years ago

If ngModal gets updated, we want to send that notifications to the jslider
Reload the slider if the value in settings has changed
Also updated min

mbukosky commented 10 years ago

Hi, The reason for this changes is to fix an issue I noticed while playing around with the directive. I noticed that changing the "value" after it had been set was not updating the UI. (For example, after an promise request) This seemed odd to me because the value was bound to ngModel. This seems like a simple enough fix.

Please let me know if you need an example fiddler to show the issue or if there is a better way to resolve this issue.

Thanks for all the help.

darul75 commented 10 years ago

hello, nice PR, I check it soon, I guess this case is not right handled yet.

rafax commented 10 years ago

Any updates on this PR? Is there something I could do to get it merged?

darul75 commented 10 years ago

In the meantime I have made a small change, I have to merge it with your PR, my fault. Or yes if you can update with master, and pull you request again, sorry I am confused about it.

mbukosky commented 10 years ago

I'll update and pull again.

mbukosky commented 10 years ago

Created new pull request #25