search

darul75 / angular-awesome-slider

:arrows_clockwise: Angular slider control directive
http://darul75.github.io/angular-awesome-slider/
MIT License
144 stars 63 forks source link

IE8 support #56

Open praswebdev opened 9 years ago

praswebdev commented 9 years ago

Hi, Do you have IE8 support? Also would like to attach the right and left arrow key events to move the slider.

darul75 commented 9 years ago

Well ;) i need to check, which angular version ?

praswebdev commented 9 years ago

AngularJS v1.2.18 getting Invalid argument. when tested in IE8

darul75 commented 9 years ago

well, I got a lot of errors too while testing on IE8 and debugging tools so frustrating, I will try again but it is difficult to spend time on this

praswebdev commented 9 years ago

looks like you are using pageX and pageY which is not defined in IE8. Used clientX and cientY, if pageX is undefined and worked in IE8

darul75 commented 9 years ago

It could be a solution if you can make PR i will test it but code is quite tricky now and maybe few other properties not handle well by ie