search

darul75 / angular-awesome-slider

:arrows_clockwise: Angular slider control directive
http://darul75.github.io/angular-awesome-slider/
MIT License
144 stars 63 forks source link

IE9 #83

Closed olegakbarov closed 9 years ago

olegakbarov commented 9 years ago

Seems like doesn't support IE9, does it?

darul75 commented 9 years ago

I do not know this browser does it really exist ?

https://github.com/darul75/ng-slider/issues/56

I have not tested yet this comment

looks like you are using pageX and pageY which is not defined in IE8. 
Used clientX and cientY, if pageX is undefined and worked in IE8
olegakbarov commented 9 years ago

Yeah, it does exists. Unfortunately. But i have no idea what could possibly be wrong.

darul75 commented 9 years ago

here fine with version 9.0.8112.16421

check by pressing F12 "Browser mode" and "Document mode"

olegakbarov commented 9 years ago

After a few hours of frustration it turned out that you need to remove console.log's from the code I almost was ready to reimplement the whole thing in jQuery :<

olegakbarov commented 9 years ago

i guess you can mark it as solved!

darul75 commented 9 years ago

jQuery ;) oh no ;) thx I will check console.log

olegakbarov commented 9 years ago

nevermind, i had all console.log's in my own code so the directive is clear

darul75 commented 9 years ago

ok thx for feedback do not hesitate, cleaning css I will then include your first idea for labels into

olegakbarov commented 9 years ago

Awesome! I'll take a look into source code this weekend and maybe will be able to help you out