search

darul75 / web-react

:diamond_shape_with_a_dot_inside: Another React Dev Kit with Webpack and NodeJS
https://react-web.herokuapp.com/
81 stars 8 forks source link

WebStorm says that AppActions is not declared in imported module. #14

Closed LarryEitel closed 9 years ago

LarryEitel commented 9 years ago

'...\app\actions\AppActions.js' line 5:

import AppActions from '../../actions/AppActions';

WebStorm complains/suggests that AppActions Default export is not declared in imported module.

Just a curious message.

darul75 commented 9 years ago

nice catch WebStorm is so strong, I will keep a look, may be caused by ES6 new features http://www.2ality.com/2014/09/es6-modules-final.html but normally just a warning

LarryEitel commented 9 years ago

I figured that much. I am new at ES6 as well. I'm using your project to learn. :) I looked at many but yours includes the key pieces I'm looking for. Especially do I appreciate your $ajax example.

darul75 commented 9 years ago

nice, me too I have learned by creating it, inspect, play, redo, good for both of us, you will build website quickly, enjoy Larry. do not hesitate

LarryEitel commented 9 years ago

Changing in AppActions module.exports = alt.createActions(AppActions);

To: export default alt.createActions(AppActions);

Makes WebStorm happier and doesn't seem to break anything.

Thoughts?

darul75 commented 9 years ago

yes it is but I will add it later, thx Larry, or do not hesitate put a PR for it

LarryEitel commented 9 years ago

I am finding more places where same refactoring is required. Will submit a PR next chance.

darul75 commented 9 years ago

:+1: sure a big refactoring is needed and it is difficult to make it alone :)

LarryEitel commented 9 years ago

Happy to help where/when I can. Are you open to discuss via Hangout/Skype?

On Tue, Aug 11, 2015 at 9:33 AM, Julien Valéry notifications@github.com wrote:

[image: :+1:] sure a big refactoring is needed and it is difficult to make it alone :)

— Reply to this email directly or view it on GitHub https://github.com/darul75/web-react/issues/14#issuecomment-129931638.

darul75 commented 9 years ago

I would like so much but it is blocked by our company proxy there ;) otherwise on darul75@gmail.com when at home

LarryEitel commented 9 years ago

Hello @darul75, been MIA on this project because I have been focusing on Redux vs Alt.

Fauzdar1 commented 3 years ago

Same issue with PHPStorm, messing things up here and then. Most of the times, it works and then suddenly stops working. Solution is to duplicate it and change the name, and it starts working again. Seriously, a mess.

I'm using it for multiple exports as 

module.exports = {
...
...
}