build-sys: remove `column -o`, deprecate `-tags tools` and introduce `GOUP_PACKAGES`

amery commented 1 week ago

Summary by CodeRabbit

New Features
- Updated the darvaza.org/core dependency to version v0.14.9 across multiple modules, enhancing performance and stability.
Bug Fixes
- Removed unnecessary whitespace handling in the Makefile generation process, streamlining output formatting.
- Enhanced logic for the build command to ensure proper handling of project directories.
Chores
- Added a new script to dynamically retrieve and compare Go versions for improved version management.

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request updates the dependency version of darvaza.org/core from v0.14.8 to v0.14.9 across multiple modules, including config, fs, net, tls, and web. It introduces a new script get_version.sh for dynamic version retrieval, modifies the Makefile to use this script for tool versioning, and removes the internal/build/tools.go file, which previously defined a package for build tooling.

Changes

Files	Change Summary
`config/go.mod`	Updated `darvaza.org/core` dependency version from `v0.14.8` to `v0.14.9`.
`fs/go.mod`	Updated `darvaza.org/core` dependency version from `v0.14.8` to `v0.14.9`.
`net/go.mod`	Updated `darvaza.org/core` dependency version from `v0.14.8` to `v0.14.9`.
`tls/go.mod`	Updated `darvaza.org/core` dependency version from `v0.14.8` to `v0.14.9`.
`web/go.mod`	Updated `darvaza.org/core` dependency version from `v0.14.8` to `v0.14.9`.
`internal/build/get_version.sh`	Added new script to retrieve and compare Go versions dynamically.
`Makefile`	Updated versioning mechanism for `GOLANGCI_LINT` and `REVIVE` tools to use dynamic retrieval.
`internal/build/tools.go`	Removed the file, eliminating the associated `build` package and its functionalities.
`.github/workflows/build.yml`	Updated Go version matrix to include Go `1.20` alongside existing versions `1.21` and `1.22`.

Possibly related PRs

86: Updates the darvaza.org/core dependency from v0.14.6 to v0.14.7, related to the main PR's update to v0.14.9.
87: Also updates the darvaza.org/core dependency from v0.14.6 to v0.14.7, establishing a connection with the main PR's changes.
97: Updates the darvaza.org/core dependency from v0.14.7 to v0.14.8, directly related to the main PR's subsequent update to v0.14.9.

Poem

🐰 In the meadow where bunnies play,
Dependencies change, brightening the day!
From v0.14.8 to v0.14.9,
A hop, a skip, all is fine!
With scripts refined and tools set free,
Let’s celebrate this code jubilee! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

deepsource-io[bot] commented 1 week ago

Here's the code health analysis summary for commits 337cf3c..5e4c606. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	❌ Failure	❗ 1 occurence introduced	View Check ↗
Go	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

amery commented 1 week ago

too broad

darvaza-proxy / x