web/assets: introduce WrapFS

amery commented 3 weeks ago

overlapping multiple fs.FS layers glob filters to determine what's acceptable try different name variants for each request

Summary by CodeRabbit

New Features
- Introduced enhanced file system handling with support for sub-filesystems.
- Added a flexible WrapFS type for layered file system access and customizable name resolution.
- Implemented a wrapFSFile struct for robust file handling and HTTP serving capabilities.
Bug Fixes
- Improved error handling for unsupported filesystem types.
Chores
- Updated dependencies to the latest versions for improved performance and features.

deepsource-io[bot] commented 3 weeks ago

Here's the code health analysis summary for commits 6fc4a7c..f6fe1a3. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Go	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes in this pull request enhance the file system handling capabilities within the web/assets package. The NewFS function now supports sub-filesystems and gracefully handles unsupported types. A new WrapFS type introduces a flexible interface for layered file system access, while the wrapFSFile struct provides synchronized access to file content. Additionally, the go.mod file has been updated to reflect new dependency versions.

Changes

Files	Change Summary
`web/assets/fs.go`	Added handling for `fs.SubFS` in `NewFS`, modified default case to wrap unsupported filesystems.
`web/assets/fs_wrap.go`	Introduced `WrapFS` type with methods for layered file system access, customization, and HTTP integration.
`web/assets/fs_wrap_file.go`	Defined `wrapFSFile` struct for synchronized access to file content, implementing multiple interfaces for file handling and HTTP serving.
`web/go.mod`	Updated dependency versions for `darvaza.org/core` from `v0.14.6` to `v0.14.7` and `darvaza.org/x/fs` from `v0.2.6` to `v0.2.7`.

Possibly related PRs

75: The changes in the fs/glob.go file involve enhancements to file system entry matching, which may relate to the new handling of different file system types in the NewFS function, as both involve improving the flexibility and robustness of file system operations.

Suggested labels

enhancement, x/fs

Poem

In the warren where files reside,
New paths and layers now coincide.
With WrapFS, we hop and play,
Serving files in a seamless way.
A filesystem dance, oh what a sight,
Hopping through code, everything feels right! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

amery commented 3 weeks ago

darvaza.org/x/web@v0.8.2 tagged

darvaza-proxy / x