search

darvaza-proxy / x

extra helpers for darvaza projects
MIT License
1 stars 0 forks source link

is there a use for the SNI parser in tls/sni? #96

Open amery opened 2 weeks ago

amery commented 2 weeks ago

hi, having ReadClientHelloInfo() using a dummy tls.Server to extract the CHI, and the Dispatcher using it. is there a use for the raw SNI parser in tls/sni?

karasz commented 2 weeks ago

tls/sni predates everything in the tls folder and was created a long time ago for handling https connection on a proxy.

I would assume that today it has zero relevance as it was overcoded by the rest of the files, /tls/server/server.go which is a very crude tls proxy still uses it.

amery commented 2 weeks ago

ok, so we need to refactor that one first

amery commented 2 weeks ago

https://github.com/darvaza-proxy/darvaza/pull/142 drops shared/tls/sni in favour of x/tls/sni