search

darwin-eu-dev / PatientProfiles

https://darwin-eu-dev.github.io/PatientProfiles/
Apache License 2.0
6 stars 5 forks source link

considering changing a couple lines of codes that uses endDateColumn #642

Closed xihang-chen closed 4 months ago

xihang-chen commented 4 months ago

Since it can no longer output NA, we may consider enhancing the codes accordingly.

For example:

  1. https://github.com/darwin-eu-dev/PatientProfiles/blob/main/R/addConceptIntersect.R#L195C1-L198C8
  2. https://github.com/darwin-eu-dev/PatientProfiles/blob/main/R/summariseLargeScaleCharacteristics.R#L417 (this is more on CohortCharacteristics side)
xihang-chen commented 4 months ago

also is.null(cdm) in addCdmName()

catalamarti commented 4 months ago

641