`ageDefaultMonth/Day` -> `ageMissingMonth/Day` ?

darwin-eu-dev / PatientProfiles

https://darwin-eu-dev.github.io/PatientProfiles/

Apache License 2.0

6 stars 5 forks source link

`ageDefaultMonth/Day` -> `ageMissingMonth/Day` ? #652

Closed catalamarti closed 3 months ago

catalamarti commented 3 months ago

https://darwin-eu-dev.github.io/PatientProfiles/reference/addDemographics.html @edward-burn

edward-burn commented 3 months ago

@catalamarti we can possibly have a look at the four arguments

ageDefaultMonth = 1,
ageDefaultDay = 1,
ageImposeMonth = FALSE,
ageImposeDay = FALSE,

Both in terms of naming, but also whether they are necessary to have at all. If people really want this level of customisation they can always edit the person table fields themselves.

catalamarti commented 3 months ago

ageDefaultMonth/Day -> ageMissingMonth/Day
deprecate: ageImposeMonth, ageImposeDay